-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for null selectors and respecting specificity. #4
Fix for null selectors and respecting specificity. #4
Conversation
Renamed some stuff to make it more distinguishable
Feature is deprecated in ruby sass. We may should print a warning to inform the user. Fixes sass#1258
Missing implementation for interpolated media queries!
Missing implementation for interpolated namespaces!
Re-armed the error handling and slightly cleaned up main block parsing function. Includes hash improvement for list as keys
Do you have a test case for this? |
yes, I can provide one. Would you like me to add it to sass-spec? |
Would be great. But please also post it here as I'm currently rebasing the whole PR and would like to test what your commits actually fix. |
bc9de62
to
659e4cb
Compare
.simple {
a: selector-replace('foo.bar', 'foo', 'foo[baz]');
} |
expected output: .simple {
a: foo.bar[baz]; } |
Also for the child-selector issue: foo {
a:&;
>bar {
b:&;
>baz {
c:&;
}
}
} expected output: foo {
a: foo; }
foo > bar {
b: foo > bar; }
foo > bar > baz {
c: foo > bar > baz; } |
ugh...sorry about the formatting.... |
I have cherry picked your commits and removed a few more bits! Thank you! |
95c72c2
to
5776e9b
Compare
a4237dd
to
962a45e
Compare
0dccd10
to
3af051e
Compare
No description provided.